-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds general task to set TES biases #545
Conversation
We could really use these functions running in the field. What's needed to get it going there? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, mostly docstring related requests.
sorry that took so long, but addressed @BrianJKoopman's feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
* Adds general task to set TES biases * Adds zero_biases task * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix typo * address brian's comments --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Brian Koopman <[email protected]>
Adds a general task to set tes biases to specified values, and a separate task to zero biases. Resolves #544.
Description
Adds a needed function to the pysmurf-controller
set_biases
that lets you generally set tes biases. Also addszero_biases
task which can makes it easier to zero all biases from OCS web.Motivation and Context
We need more control over TES biases from pysmurf-controller.
How Has This Been Tested?
Not tested yet.
Types of changes
Checklist: